http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Kyle M Hall <[email protected]> --- (In reply to comment #12) > (In reply to comment #11) > > Created attachment 12281 [details] > > [SIGNED-OFF] Bug 8559 - conflicting item statuses - Force cancel or revert > > Signed-off-by: Owen Leonard <[email protected]> > > > > All three cases tested, correct outcome each time > > > just a little QA thing... > > please fix patch so RevertWaitingStatus takes a scalar I don't see a compelling reason to do that, there are plenty of subroutines that pass hashes for parameters. Perhaps its because the subroutine only takes one parameter now, but we don't know what parameters will be added in the future. I believe that we should move to using hashes for all future subroutines. How many subroutines does Koha have that have a ton of parameters? And it's even better when half the passed in params are undef. If we switch to hashes for parameters, rather than arrays, it will not only simplify our code, but make it more self-documenting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
