https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734
--- Comment #12 from Martin Renvoize <[email protected]> --- (In reply to Jonathan Druart from comment #10) > 1. > 69 tendered => scalar $input->param('tendered'), > > Looks like this var is not used in the notice template. This is used in the subsequent bug that enhances the printed slip to include 'change' and 'tendered' amounts (These are both in our local slips for customers) > > 2. > 65 credits => $credit_id, > 66 borrowers => $patron->borrowernumber > > Should not we remove borrowers/[% patron %] and use credit.patron instead? Whilst I agree with this and liked the idea. Katrin muted it saying that the 'patron' (or rather 'borrowers') should always be available at the top level to allow for simple syntax for the end-users writing slips. I think this is debatable.. but that's why it's there in the first place ;) > > 3. > + - "[% PROCESS 'accounts.inc' %]" > > There is no precedence for that (using an include file from a notice > template). > Don't know if it's a good idea or not. Does it work with translation? It's actually there precisely for translation purposes.. though I need to test it.. I'm pretty sure we pass 'lang' through but whether we pass it correctly to refer to the right translated path I'm not sure.. I should take a look, thanks :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
