https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808

Tomás Cohen Arazi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[email protected] |[email protected]
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #13 from Tomás Cohen Arazi <[email protected]> ---
It works as expected, and the proposed solution is correct-ish.

It does the job and actually is very optimal!
Anyways, I submitted a follow-up that can be dismissed, which makes the
AddIssue method actually refresh the $item_object, because I fear this might
not be the only side-effect (from calling AddReturn) that might present edge
cases (like overwriting the wrong things, etc).

Food for thought, and more opinions. As I said, my follow-up can be skipped. It
actually makes an extra DB call compared to your patch, Kyle.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to