https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #96 from Martin Renvoize <[email protected]> --- Comment on attachment 113967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967 Bug 22690: Refactor merging of records to improve performance (Elasticsearch) Review of attachment 113967: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +1082,5 @@ > + > +$params: > + skip_record_index => 1|0 > + > +Returns undef if the move failed or the biblionumber of the destination > record otherwise I wonder if this might be nicer as a fluent interface (i.e returning $self so it can be chained.. the undef return would become a no-op and the final return would be the updated Koha::Item object?) One for later perhaps ::: Koha/Schema/Result/Item.pm @@ +778,4 @@ > '+exclude_from_local_holds_priority' => { is_boolean => 1 }, > ); > > +# Relationship with orders via the aqorders_item table that not have foreign > keys Was there a reason not to add the foreign key and let dbic generate the relationship? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
