https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690
Joonas Kylmälä <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117062|0 |1 is obsolete| | Attachment #117063|0 |1 is obsolete| | Attachment #117064|0 |1 is obsolete| | Attachment #117065|0 |1 is obsolete| | Attachment #117066|0 |1 is obsolete| | Attachment #117067|0 |1 is obsolete| | Attachment #117374|0 |1 is obsolete| | --- Comment #28 from Joonas Kylmälä <[email protected]> --- Created attachment 117507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117507&action=edit Bug 25690: Remove double usage of 'Reserved' return value The patch "Bug 19116: Hold not set to waiting after transfer" added a new meaning to 'Reserved' return value of C4::Reserves::CheckReserves function. Let's remove double usage and have separate Transferred return value so we can differentiate between attached and non-attached holds. This will come useful in future refactorings. This patch does no changes to the logic except in the /cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give similarly to waiting state notice about hold being transferred. To test: 1) Apply this patch 2) Create a new item level hold so that pickup library is different than where the item is currently. Then return the item so that hold is being attached and transferred. 3) Go to branchtransfers.pl and try to create a new transfer: it should prompt you with message "Item is attached to a hold and being transferred for XXX" and provide you with option to cancel the hold or to ignore the transfer. Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
