https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740
--- Comment #9 from [email protected] --- (In reply to Owen Leonard from comment #6) > Some comments: > > 1. We don't need new CSS to hide the heading on the main page. We can add > the Bootstrap class ".sr-only" > Okay cool, didn't know about that class. Thanks, will amend that. > 2. I don't think it's necessary to add headings inside <caption> and > <legend>, e.g. opac-memberentry.tt: > > - <legend id="mainaddress_legend">Main address</legend> > + <legend id="mainaddress_legend"><h2>Main address</h2></legend> > > Semantically speaking I think the legend is correct, and that the heading > isn't necessary. Is there a particular accessibility tool behavior you're > trying to address? > > 3. It is invalid to put a heading tag inside a <label> (e.g. > opac-advsearch.tt). I have the same question as above about whether this > change addresses some specific need. The reason we are putting heading tags in things such as legends and labels is that they appear to visually be heading a particular block on a page. We out the <h> tags inside the legends and labels as we were not sure what the best way to include them was, and we didn't want to remove the legend and label tags. With screen readers, it is easiest for a person to scan through the page by headings, to get an idea about the certain areas of the page. We don't believe it is possible to scan through the page using legends or labels, and even if it is possible, we think that this is an inconvenience to screen reader users as they would have to be aware of the legends and labels to know to do this. If you are aware of a better way to include these headings, please let us know. One option we thought of was to possibly remove the headings from the labels and legends and put them outside and hide them. > > 4. I disagree that a heading shouldn't be used inside a message like this > (opac-results.tt): > > <div class="dialog alert"> > - <h4>Error:</h4> > + <p><strong>Error:</strong></p> We will make a follow-up patch to move some of these alerts back to headings, but move them up levels so they are in the correct hierarchy. Some of these however, are not meant to be headings as they have no information under them, so these do need to be dealt with. > > 4. This patch adds an invalid file: .opac-readingrecord.tt.swo Oh yes thanks, will remove this. Thanks again for all your feedback! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
