https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27963
Joonas Kylmälä <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Joonas Kylmälä <[email protected]> --- Hmm, now that you added the "return unless $item" (which is actually a really good solution I didn't think of) wrapping the whole block in the eval is not needed, only for the store it is. The call to ->make_column_dirty only throws exception if the DB column doesn't exists at all and in that case we can just halt the execution of the program completely because it won't magically appear later on. v3? :P I also looked further now into fc09b0d491b1 / Removal of ModItem and actually since the modification script was originally *not* explicitly passing the location and date fields as the fields we wanted to update it didn't do that. Only the %derived_columns listed in 2677da8f1 commit were modified, so items.cn_sort if either itemcallnumber or items.cn_source is modified. So here we need to mark only itemcallnumber and cn_source as dirty. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
