https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787
--- Comment #10 from Martin Renvoize <[email protected]> --- I rebased this to test.. and have a couple of thoughts. 1. You've missed a few cases.. perhaps they were introduced since you wrote the patch.. or perhaps you weren't intending to catch all strings? 2. I'm not seeing any special handling for the existing functionality added with bug 12571... I'm not even sure how you'd go about it. The first point is minor and easily resolve, but I'm a little more worried about the second. As far as I understand, the find and replace based overrides in bug 12571 work at the SIPServer login level.. this means you can override the messages differently for different terminals.. however with your patch, it would be very easy for staff to inadvertently break these per-login value's if they changed away from the defaults at the syspref level. CCing a few people to ascertain whether this is actually a problem or not... If it's not something that needs defining at a login level then I'd be inclined to replace that functionality entirely with this patchset. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
