https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508
Martin Renvoize <martin.renvo...@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118765|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- Created attachment 118776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118776&action=edit Bug 25508: Do not attempt renewals if syspref is disabled In the case where 'RenewAccruingItemWhenPaid' is disabled we were still testing whether the fine item was renewable ragerdless. This has two issued: 1. A minor performance issue with us running more code than required. 2. The return value from renew_item when the syspref is disabled was empty, but it would still get appended to the 'renew_outcomes' array which results in some 'dirty' messages in the UI. Test plan 1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off 2 - Checkout an item to a patron and make it overdue (can backdate the checkout) 3 - Make sure the itemtype has fines that will be charged 4 - Charge the fines: Set finesMode = production perl misc/cronjobs/fines.pl -v 5 - Check the fine appears on the patrons account 6 - Pay off the fine 7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below: No title ( ): Not renewed - Unknown error" 8 - Apply the patch 9 - Repeat steps 1 through 6 and note that you no longer trigger the error message. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/