http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8895

Jonathan Druart <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |m

--- Comment #5 from Jonathan Druart <[email protected]> ---
QA comments:

1/ The line:
    unless (defined $data->{value}) { $data->{value} = "";}
could be wrote as:
    $data->{value} //= "";
(with Modern::Perl).

2/ The Bug 2505 collects this kind of patch :)

3/ The line 424 has a useless test if defined( $data->{value} )

Marked as Failed QA for 3

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to