https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27740
--- Comment #20 from [email protected] --- (In reply to Martin Renvoize from comment #16) > OK, So, I added a couple of follow-ups that would be worthwhile checking. > > I also notice that on the opac-main page, once logged in you can be > presented with a malformed header hierarchy still.. > > 1. The 'user_summary' block, where is says "Welcome, user" in the top of the > box on the right side of the page.. that's an 'h3'.. I'm not sure it should > be a header element at all.. it's a 'box title'.. thoughts? > 2. If the quote of the day feature is enabled, we display a 'Quote of the > day' heading above all over content in the 'main' content area of the page.. > that is also an 'h3' which doesn't feel right... maybe this should be > converted to more of a clear 'content box, with a title' again, instead of > looking like part of the main content of the page with a standard header? > > Given the above I think I need some feedback before being able to PQA Hi Martin! Thanks so much, I tested and signed off your 2 follow-up patches. Yes I agree that the "Welcome, user" shouldn't actually even be a heading. I can make a follow up patch to amend this now. I also agree the Quote of the day is incorrect so I'll make a follow up patch to amend that too. Thanks again! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
