https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28169
--- Comment #1 from Andrew Nugged <[email protected]> --- Created attachment 119853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119853&action=edit Bug 28169: Add quotes around value in template to render proper JS There is code in request.tt: homebranch: "[% ... %]", holdallowed: [% ... %] There only digits where expected earlier in holdallowed but now it can be string value ('from_any_library' for example), so it should be in quotes. To reproduce the problem: 1. Add circulation rules which allow 1 hold only to the itemtype 2. Make sure AllowHoldPolicyOverride syspref enabled 3. Make 1 hold to patron for any biblio which has a few items available, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 (this biblio record has 4 items) 4. Start another hold for same patron on any biblio record or the same, and keep browser's JS console open, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 5. You should see now JS error in browser console: Uncaught ReferenceError: from_any_library is not defined Uncaught ReferenceError: columns_settings_borrowers_table is not defined 6. Apply the patch 7. Repeat the steps 4-5 (reload the page) and now the JS error should be gone -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
