https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27995
Martin Renvoize <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119204|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <[email protected]> --- Created attachment 120011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120011&action=edit Bug 27995: Update return for Koha::Account::Line->apply This patch updates the return value of Koha::Account::Line->apply to return the updated Koha::Account::Line object with Koha::Object::Messages embedded for the results of any triggered renewals. Available credit, the former return value, is still availabe via the object directly as `amountoutstanding`. Koha::REST::V1::Patrons::Account->add_credit has been updated to reflect the change. No other area's of Koha relied upon the return value. This patch also fixes a bug whereby if you passed a list of debits with an outstanding debit larger than the outstanding credit then you could end up with superflous offest lines with zero amounts that was highlighted by the improved unit tests in t/db_dependent/Koha/Account/Line.t Test plan 1/ Run t/db_dependent/Koha/Account/Line.t 2/ Run t/db_dependent/api/v1/patrons_accounts.t 3/ If both tests pass then signoff Signed-off-by: Tomas Cohen Arazi <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
