https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27916
--- Comment #15 from Martin Renvoize <[email protected]> --- (In reply to Marcel de Rooy from comment #14) > When looking at SIP and Accounts, I noticed that renew_item should already > crash on an invalid itemnumber: > my $itemnumber = $self->item->itemnumber; > So I am wondering if your adjustments are enough? Or should we already do > something here too? In theory, one should always have called 'is_renewable' prior to calling 'renew_item'.. and 'is_renewable' performs the check for existing item.. so we shouldn't hit the problem you're foreseeing.. in theory. I'm going to investigate the unit tests side again and hopefully at the same time I will work out where things are going. Thanks for reviewing Marcel, this code is all rather complex and all the eyes and perspective we get are useful. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
