https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Alex Buckley <[email protected]> --- (In reply to Henry Bolshaw from comment #5) > Thanks Alex, this is a real improvement! I followed the test plan and > everything worked as you said it would. > Thanks Henry! Apologies for the delay getting back to you I've been moving house. I've attached patches addressing two of your points below, and a third patch refactoring the code - creating a new subroutine in Koha/Patron.pm to remove code duplication. > > Option to Remove items from list? > ----------------------- > This patch allows other library staff to add items to the list but it > doesn't give them the ability to remove items. Is this functionality you are > planning to add as a subsequent patch or do you see that as a separate bug? > Without the ability to remove items, the interface is slightly confusing > because both the OPAC and staff interface still give library staff the > option to remove items - but if they try then there's an error, "no record > was removed". > > This should have been added by one of the patches I have attached. > > Update Edit list hint message > ----------------------- > On the staff interface when creating or editing a list, if you select "Allow > changes to contents from: Staff Only" while the category is still private, > you get this hint: "The Anyone permission has no actual effect while this > list is strictly private." Can you tweak this to reflect the new staff > permission options? > This should also have been added in one of my new patches. > > No staff only option in OPAC > --------------------- > The staff only option doesn't appear in the OPAC, so if the list owner edits > a list from the OPAC - e.g. to edit the name - the list permissions will > change. I don't know if this is easily fixable because you wouldn't want the > staff only option appearing for all users but I thought I'd mention it. > I completely agree with you. I'm not 100% sure how to go about fixing this. Perhaps it could be a follow-up fix? I am part way through another patch for this bug report adding unit test coverage, that will hopefully be finished sometime next week. So I'll keep the status as 'Assigned' for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
