https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28369
--- Comment #12 from Tomás Cohen Arazi <[email protected]> --- (In reply to Ere Maijala from comment #11) > (In reply to Tomás Cohen Arazi from comment #6) > > (In reply to Joonas Kylmälä from comment #5) > > > (In reply to Tomás Cohen Arazi from comment #4) > > > > Yes! Can certainly do! > > > > > > > > But as I mentioned, the PUT route is using (in the code) different > > > > attribute > > > > names than the API spec, so you need to check if it isn't broken already > > > > (20.11). I couldn't find the references to the API routes on that PHP > > > > code. > > > > > > The code is in the function changePickupLocation. The code in > > > changePickupLocation uses the attribute names that work (instead of broken > > > ones). > > > > Ok, I'm fine with fixing the spec and adding a deprecation warning, and > > adding PATCH as a duplicate for PUT. > > > > Do you agree? > > Works for me (I'm responsible for the KohaRest PHP module). As a side note, > it would be really nice if PATCH was able to modify priority, suspension and > suspension end date as well as pickup location. From an API user's > standpoint modifying several attributes of a hold is typically a single > operation, and having to make several API calls makes using it convoluted. Luckily, it works like that! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
