https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565
--- Comment #266 from David Cook <dc...@prosentient.com.au> --- I need to finish up for the day, but... I reckon we need something like this: Koha::Holds->remaining_reserves_total({ patron => $patron, }); maxreserves (global system preference) "Holds allowed (total)" (circ rule: reservesallowed) Koha::Holds->remaining_reserves_record({ patron => $patron, record => $biblio, }); "Holds per record (count)" (circ rule: holds_per_record) Koha::Holds->remaining_reserves_today({ patron => $patron, record => $biblio, }); "Holds allowed (daily)" (circ rule: holds_per_day) And each needs to consider an unlimited number (although in theory maxreserves should always be a positive integer). Then when you're checking boxes you check each of those totals in turn. (The reason for having separate functions is so that you can tell the user what limit they've exceeded...). An unlimited rule should probably return a null response, so that you only consider counts that are digits. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/