https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420
--- Comment #17 from [email protected] --- Hi David, I think a lot of the code that you see in the new AzureAD "oidc" code is just left over from the old Google "oidc" code. Remember: my goal was to quickly get something that works and is reasonably secure without making any major changes to existing code. So the patch is purely additive. Basically, I made a copy of the googleopenidauth file and changed a few things to make it work with AzureAD. This also gave me better than even odds of adhering to the coding style, etc. However, I have also brought along whatever problems were there in the old code. I'll post a diff here so you can see which parts are from me and which parts were already there. In any case, this is probably not the *right* way to do it. But it's fast, and probably does no real harm since whatever problems it has are the same as the ones with the google version. Make sense? -mark -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
