https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519
Jonathan Druart <jonathan.druart+k...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #5 from Jonathan Druart <jonathan.druart+k...@gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #4)
> I agree, generally. but:
> 1. You are adding an unadvertised die in C4::Auth (I agree with it!). Please
> add a test for that behavior.
This die is obvious (I added it when I wrote a patch for bug 17427 more than 4y
ago - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56504).
Writing a test for it is not trivial and I would not block the whole change for
that.
> 2. I think you should simplify your patch by just putting the CGI/ dir in
> the top level. In that case, you would just do what we do for C4, Koha and
> the OpenILS library directories in Makefile.PL (& friends). No complex hacks.
I think it makes sense to have it in lib.
> I would love to move all libs to a libs/ dir, but lets do it on a separate
> bug, and discuss the tradeoffs there (my butt has been kicked a couple times
> when I proposed it, because of all bugzilla patches not applying if we did
> that).
Like having intranet controller scripts in their own directory (bug 9949).
Could be part of a roadmap topic, but definitely not something for 21.11.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
