https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Marcel de Rooy <[email protected]> --- (In reply to Nick Clemens from comment #15) > (In reply to Marcel de Rooy from comment #14) > > + unless($record->field('001')){ > > + $record->insert_fields_ordered(MARC::Field->new('001', > > $biblionumber)); > > + }elsif($record->field('001')->data() eq 'biblionumber'){ > > + $record->field('001')->update($biblionumber); > > + } > > > > Please explain. > > Why do you test eq 'biblionumber' ?? > > Why not always overwrite 001 with $biblionumber if the pref is set ? > > Similar to autobarcode or automembernum - we will default, but if you force > a new value we let it stand - I think allowing the librarian to force a > different number allows for collections that fall outside the norm. > > It could be useful for an OAI set for instance Maybe you do not understand my point? Read this line: > > + }elsif($record->field('001')->data() eq 'biblionumber'){ You are comparing with the string biblionumber ! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
