https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122055|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <[email protected]> --- Created attachment 122224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122224&action=edit Bug 28514: Remove getletter The way we handle notice templates is confusing (see bug 27660, bug 26787, bug 28487). This patch remove C4::Letters::getletter and use either Koha::Notice::Templates->find or the newly created methods ->find_effective_template that will do all necessary to return the correct template. Test plan: - Create and modify notice templates - Make sure you have TranslateNotices turned on and that some notices templates have a translated version - Use holds_reminder.pl and overdue_notices.pl cronjobs and confirm that the generated notices are the expected ones - Test also pos/printreceipt.pl - And finally test some other notices (CHECKIN, RENEWAL for instance) Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Marcel de Rooy <[email protected]> [EDIT] Amended by removing comment for $params={%$params} JD amended patch: * Add missing POD * Fix spelling (dont ==> don't) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
