https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Marcel de Rooy <[email protected]> --- Agustin: I still have some doubts about the atomicupdate. You do an UPDATE for notice AR_PENDING and an insert for the new AR_REQUESTED. Generally we should be very careful with UPDATES on existing notices. This one is too generic and will unnecessarily? remove customized texts. The insert could be an INSERT IGNORE btw. I would suggest to use a new name for the former AR_PENDING notice and only rename it in the atomicupdate. Like AR_RECEIVED. Do not touch the text. And after that add a 'new' notice AR_PENDING (..) with the new text. In the second patch you add AR_REQUESTED but note that you insert the text for the PENDING state ! So you mix them up here. Obviously, the changes for patch1 should reflect in patch2. Changing status -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
