https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142
--- Comment #9 from David Cook <[email protected]> --- Comment on attachment 122284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122284 Bug 3142: Add itemlost, withdrawn and onloan Review of attachment 122284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3142&attachment=122284) ----------------------------------------------------------------- ::: Koha/Items.pm @@ +53,5 @@ > + itemlost => 0, > + withdrawn => 0, > + notforloan => { '<=' => 0 } > + , # items with negative or zero notforloan value are holdable > + onloan => undef, Why is onloan undef here? If I recall correctly, there are some rules/system preferences for determining holdability based on loan status. For instance, some settings only allow you to place holds if an item is already checked out. But then there is "allow on shelf holds" where "onloan" would be irrelevant. So it's probably a better idea to create the hashref earlier in the function and then changing the hashref based on rules/settings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
