https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

Marcel de Rooy <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #10 from Marcel de Rooy <[email protected]> ---
(In reply to Martin Renvoize from comment #9)
> Tests pass, QA scripts pass and the code looks reasonable.
> 
> I'm not entirely sure about the method name.. we now have:
> 
> Koha::Biblio->get_marc_notes;
> 
> and
> 
> Koha::Biblio->get_authors_from_MARC;
> 
> For consistency, I think I'd prefer this patch to introduce
> 
> Koha::Biblio->get_marc_authors;
> 
> But... I think we can leave that decision to the RM.. so Passing QA :)

I would also prefer get_marc_authors.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to