https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
--- Comment #51 from Martin Renvoize <[email protected]> --- Oops, I started looking at this on Friday but got pulled away into other things.. I hope to get back to it later this week. One comment so far however.. I think the 'host_record' relationship accessor could be generalised a little more to make it less specific to this feature and thus adoptable by other uses in the future. I'm happy to undertake this as a QA follow-up. I think we should move the item count test and syspref check out of the module method and into the controllers instead.. as much as this goes against the instinct to make sure it's testable I think this will lead to a much more flexible low level object method... I wonder if we could move the test into the integration tests so it's still caught but at the controller level rather than the object? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
