https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #28 from Marcel de Rooy <[email protected]> --- (In reply to Martin Renvoize from comment #23) > I think the `C4::Context->preference('ArticleRequests')` check here is > superfluous to requirements.. I would hope we are checking that the feature > is enabled prior to this point and also don't think it makes sense to check > them together. Yes, that seems fair. > > + library_id => C4::Context->userenv ? > > C4::Context->userenv->{'branch'} : undef, > > I wonder if this should default to the items home library? I presume > there's no requirement, for now at least, for these charges to be library > specific? Interesting! How important is branchcode for the accounts subsytem? kohastructure refers to the place where a payment was made or an invoice created, etc. The article request contains a branchcode for the pickup library btw. It might not be relevant indeed, but I feel that the charge is created at the branch where the article is actually copied or scanned. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
