https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
David Cook <dc...@prosentient.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dc...@prosentient.com.au
--- Comment #3 from David Cook <dc...@prosentient.com.au> ---
I like the motivation for the change, but I'm not sure about the style. What if
we moved most of the logic out of "custom_cover_image_url" and into a separate
class method. Then "custom_cover_image_url" could call that class method, and
that class method could be used in the search results. I think that would make
the code easier to read and maintain in the longer term.
But that's just my two cents. I know that it would be more work so might not be
feasible. I've used the same style of checking if $self is a ref for times when
I couldn't refactor more fully.
Always nice to see an efficiency improvement :)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
