https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #50 from Marcel de Rooy <[email protected]> --- acqui/neworderempty.pl: my ($marcrecord, $encoding) = MARCfindbreeding($params->{'breedingid'}); acqui/neworderempty.pl:=head2 MARCfindbreeding acqui/neworderempty.pl: $record = MARCfindbreeding($breedingid); acqui/neworderempty.pl:sub MARCfindbreeding { acqui/neworderempty.pl: my ($marcrecord, $encoding) = MARCfindbreeding($breedingid); authorities/authorities.pl:sub MARCfindbreeding_auth { authorities/authorities.pl: ( $record, $encoding ) = MARCfindbreeding_auth( $breedingid ); cataloguing/addbiblio.pl:=head2 MARCfindbreeding cataloguing/addbiblio.pl: $record = MARCfindbreeding($breedingid); cataloguing/addbiblio.pl:sub MARCfindbreeding { cataloguing/addbiblio.pl: ( $record, $encoding ) = MARCfindbreeding( $breedingid ) ; => Can we consolidate this in a module ? Do we need a (small) extra test for the new itemrecord parameter in PrepareItemrecordDisplay ? Another crash: my $alliteminfos = C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues( $marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note', 'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price', 'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] ); Test plan The whole workflow is not completely clear to me here. We should have a solid test plan that tells me how I can verify it this development really works as we hope it does. With the changes and time passed, a new signoff from someone with Acquisition experience would be welcome. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
