https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435
--- Comment #193 from Martin Renvoize <[email protected]> --- (In reply to Jonathan Druart from comment #192) > Martin, shouldn't we apply the following change to make the db rev > idempotent? > > - $dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != > 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND ( debit_id IS NULL OR > credit_id IS NULL)" ); > + $dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != > 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND type != 'APPLY' AND ( > debit_id IS NULL OR credit_id IS NULL)" ); Hmm, it wouldn't do any harm, though I believe we shouldn't have any cases where APPLY exists where debit_id or credit_id is null. Thanks for the whitespace fix, I'll have to double check my git config.. seems I lost something on the last reset of that environment. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
