https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Owen Leonard <[email protected]> --- On booksellers.tt, you add a "Search for vendor" h1 even though there is already an h1 on the page, "Vendor search: X results found." Is this intentional? I looks like it's redundant. The same is true on circ/bookcount.tt and on catalogue/detail.tt, where the original H1 is output by the XSL template. The labelled MARC detail page shows an error, and the QA tool catches it too: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt line 94: unexpected token (END) [% END %] On circ/branchtransfers.tt the heading "Branch transfers" uses incorrect terminology. Despite the name of the file we use the term "Library" everywhere instead of "branch." On this page however I think the heading is redundant, and the existing <legend> could probably be converted to a heading. In many files the position of the toolbar relative to the heading has been changed. I agree that we lack consistency in how this is handled, but from what I can see this patch doesn't resolve that inconsistency. I would prefer that this patchset omit the changes to toolbar position so that it can be addressed separately. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
