https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729

--- Comment #2 from Jonathan Druart <[email protected]> ---
What's the expected behaviour? For each of the headers! :)
Because it's confusing.

I can confirm the bug in master:
KohaAdminEmailAddress => [email protected]
ReturnPathDefault => [email protected]
No emails defined at library level

"""
From: [email protected]
Subject: Checkouts
To: [email protected]
Sender: [email protected]
"""


My proposed fix would be:

diff --git a/C4/Letters.pm b/C4/Letters.pm
index 177a4f51f67..ca02293c492 100644
--- a/C4/Letters.pm
+++ b/C4/Letters.pm
@@ -1372,6 +1372,7 @@ sub _send_message_by_email {
     my $from_address =
          $message->{'from_address'}
       || $branch_email
+      || $branch_returnpath
       || C4::Context->preference('KohaAdminEmailAddress');
     if( !$from_address ) {
         _set_message_status({

But I am not sure what should be used for "From" and "Sender".

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to