https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #67 from Alex Buckley <[email protected]> --- (In reply to Marcel de Rooy from comment #63) Hi Marcel, * Follow-up patch attached containing fixes for comments #59 and #61. Could you please take a look? * Regarding comment #60: I've been testing this today. When a 'staff only' list is created both the virtualshelves.allow_change_from_owner and virtualshelves.allow_change_from_staff values are set to 1 (see below): | allow_change_from_owner | allow_change_from_others | allow_change_from_staff | +-------------------------+--------------------------+-------------------------+ | 1 | 0 | 1 | +-------------------------+--------------------------+-------------------------+ So the first condition ($self->owner == $borrowernumber && > $self->allow_change_from_owner) is true when a staff member who owns a 'staff > only' list and doesn't have the staff_only_lists permission tries to > add/delete an item from their list. i.e. they can add/remove an item in their > cart. Am I perhaps missing something? * Regarding comment #62: When you refer to anonymous user do you mean logging in as the borrower set in the AnonymousPatron system preference? When I log into the OPAC as borrower 53 (AnonymousPatron = 53), do a search, click 'Save to lists' under a biblio, then public lists set to "Allow changes to contents from=Anyone seeing this list" show in the "Select a list" dropdown (I've attached a screenshot showing 'public' displaying in the Add to a list page), I can then add the item to that list. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
