https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #8 from AgustÃn Moyano <[email protected]> --- Hi Marcel, (In reply to Marcel de Rooy from comment #7) > Hi Agustin, > > I found a few problems :) > > [1] Category AR_CANCELLATION has no description. See Admin form. Ok, I'll add a description right away > [2] There are no authorized values defined for AR_CANCELLATION ? The dbrev > should also add the reasons added to auth_val.yml. In the first attach there are authorised values in auth_val.yml.. I was not sure to add them in atomicupdate, and then I saw HOLDS_CANCELLATION did not add authorised values in the update. > [3] There is no longer a possibility to add a custom reason for cancelling > (as we had). The default reasons should be additional, not excluding free > text. Ok, I'll try to restore the way it was... what happens if patron selects a reason, and then adds a custom text?.. which one wins? > [4] Your request for an article from Learning Perl () has been canceled for > the following reason: [blanks] > => The selected reason is not mentioned in the notice ! Note that the reason > is saved correctly in the database. Ups! I'll check notices > [5] Why do you add cancel_article_request to Koha/REST/V1/Patrons.pm ? Apart > from checking existence of the patron id, what is its use ? As I was making API endpoints for cancelling article requests from staff interface (we should move away from svc in any chance we've got), I thought it would be good to add the same for opac.. the endpoint that opac uses is DELETE /api/v1/public/patrons/{patron_id}/article_requests/{ar_id}, so It seemed natural to place it in Koha/REST/V1/Patrons.pm Cheers -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
