https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #94 from Jonathan Druart <[email protected]> --- (In reply to Andrew Nugged from comment #92) > 1: yes, naming can be added > > 2: this is a "placeholder" which: Yes, I got that, and L for Left and R for Right. But then XI for... what? :) > 3: because it has " .. ? .. : .." depending of what bracket was found No, the second regex does not have it. > , but > otherwise if you speaking security-wise and don't want to have "e"'s at all > this RE probably can be split to few "just with different brackets" each, > should Petro split this regex to two without "e"? We discussed this too, I > also pointed that this is less secure "if something changes", but in this > case, I don't see how this can be hacked (how?) Looks ok for now. But if it can be avoided I should do it. > 4: for sure, this is good point. And some more comments in code. Let's do > this. Thx! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
