https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
--- Comment #18 from Tomás Cohen Arazi <[email protected]> --- (In reply to Jonathan Druart from comment #17) > (In reply to Tomás Cohen Arazi from comment #16) > > Can we add a new table for the 2FA secrets please? > > Why? > Adding it means that the code needs to be adjusted as well, to deal with 1-N > relationship at DB level. IMO the DB structure should reflect the UI. If we > need it later it will be easy to move it to a separate table. 2FA secrets (and the same for overdrive tokens, etc) are not part of the 'patron' entity. Changing the model like this to avoid a new table has another side effects: you will need to remove it in Koha::Patron::to_api_mapping, and if we want to add routes for dealing with them, the code will look weird. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
