https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #81 from Jonathan Druart <[email protected]> --- 1. +my $can_request = $borrower->can_request_article $patron is better now 2. + my $compdate = dt_from_string->add( days => -1 ); I don't understand, what are we doing here? Can you add a line in the POD about that? 3. + if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) { + push @messages, {type => 'error', code => 'article_request_numeric_limit' }; + $op = 'add_form'; + } elsif ($article_request_limit ne '' && $article_request_limit < 0) { + push @messages, {type => 'error', code => 'article_request_negative_limit' }; + $op = 'add_form'; + } else { Why that? I am expecting to see a JS validation and an exception raised in Koha::Category->store. But not in the controller. 4. circ/request-article.pl + error_message => 'Patron cannot request more articles for today' <p>[% error_message | html %]</p> Hum? Non translatable message. Same for the exception actually: + error_message => $_->{message} And same in opac-request-article.pl 5. opac-request-article.pl + exit unless $_->[0] && $_->[0] eq 'EXIT'; This is very awkward. Why not simply having the print+exit outside of the try? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
