https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #380 from Jonathan Druart <[email protected]> ---
Review, all patches squashed:

1. +use Encode qw(decode);
Not used in C4/XSLT.pm
One patch is saying that we need it, but the squashed version does not show
that.

2. ES index added to the default mappings but to the upgrade process. Is that
expected?

3.
+[% IF ( ComponentParts ) %]<li id="components_tab"><a
href="#components">Components ([% ( ComponentParts.size ) %])</a></li>[% END %]

+                                <a href="#components">Components ([% (
ComponentParts.size || 1 ) %])</a>

=> Missing filter AND not consistent (the '|| 1')

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to