https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700

--- Comment #28 from Andrew Nugged <[email protected]> ---
Jonathan: 

yours (and my patch over it) solution is separated from Petro's one (so Petro
should re-do sending to logs refs/objects instead of concatenated strings), 

but this solution works also in limited scope: only for logging, "unblessed"
still behaves sometimes by "bringing non-scalars" for developers in other
places, i.e. I'd say "partial solution" (bug still there).

Why I am still hesitating about "get_from_storage" – as it is written in docs:
https://metacpan.org/pod/DBIx::Class::Row#get_from_storage

"This copy can then be used to compare to an existing result object, to
determine if any changes have been made in the database since it was created."

that said it fetches copy from storage, "to compare", which means, it even CAN
DIFFER from current data precollected in dbic object,

but we are not allowed to "force" "store" by "unblessed": that will be +1 more
unexpected behavior... Eh?

And another "con" against "get_from_storage" is that +1 SQL request
(productivity POV).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to