https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #480 from Martin Renvoize <[email protected]> --- Fair enough, if you feel we should move the check back to the two controllers I'm OK with that.. I've DRY'd the code in other regards now so that bit of refactoring can get undone. You're incorrect in saying that the search query would have ever been executed twice though.. we do not use the 'Details' templates for the display of the component parts when inlined, so the block with the query within it would not have been executed. Regarding having the 'Show analytics' link regardless of the preference.. that's fine too; Though personally, I feel it perhaps confuses the end-user with two links to display the same information.. one without a re-fetch and one with. I feel this bug has gone on long enough and any further refinements should be in their own bugs.. it worries me that so much is still going on at the end of the development cycle of the bug personally. Don't you also need to remove some XSLT tests if you're moving the code back out into the Controllers? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
