https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349
Martin Renvoize <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125875|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <[email protected]> --- Created attachment 127028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127028&action=edit Bug 28349: (bug 26234 follow-up) Correct wrong array merge Bug 26234 allowed to remove the different classes we use in aoColumnDefs for sorting columns of table using DT. However there is a terrible mistake, the merge of existing aoColumnDefs array with the default one is totally wrong: $.extend(true, new_parameters, default_column_defs); When we actually wanted to do: $.extend(true, new_parameters["aoColumnDefs"], default_column_defs); But it's still wrong, extend is doing a deep copy and the array will be replaced by the other one, whereas we want to append. We want to merge default_column_defs with the existing aocolumnDefs, this patch is doing it explicitely. This bug only exists when there is an existing aocolumnDefs. See commit d3f3a55e0b1544ebcd3166d141e126a4324baab1 It happens on: * cataloguing/z3950_search.tt * reports/guided_reports_start.tt * serials/subscription-detail.tt * opac-course-reserves.tt * opac-detail.tt However this bug has been hidden as we have in master related bug from bug 27945, which removes title-string. Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
