https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from David Nind <[email protected]> --- Testing notes (using koha-testing-docker in strict SQL mode - the default when starting with ku). Setup for testing ~~~~~~~~~~~~~~~~~ 1. AutoRenewalNotices system preference - set to "according to patron messaging preferences". 2. Checked out some items to patrons (I checked out one item to three different patrons) - when checking out expanded "Checkout settings" and selected automatic renewal and added a date before the current date for "Specify the due date". 3. For those patrons added an email address ([email protected] for example) and changed their patron messaging preferences to enable email notification for auto renewal. Error message before patch applied ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I didn't get "returns 255 error code on exit", but it clearly wasn't working as I got: perl misc/cronjobs/automatic_renewals.pl -c -s -v getting auto renewals No method count found for Koha::Checkouts DBIx::Class::ResultSource::_resolve_join(): No such relationship borrower on Issue at /kohadevbox/koha/Koha/Objects.pm line 601 at misc/cronjobs/automatic_renewals.pl line 136. Use of uninitialized value in concatenation (.) or string at misc/cronjobs/automatic_renewals.pl line 136. found auto renewals DBIx::Class::ResultSource::_resolve_join(): No such relationship borrower on Issue at /kohadevbox/koha/Koha/Objects.pm line 335 After applying patch and running automatic renewals ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Checked the check outs for patrons and made sure items were renewed - noted new due dates. 2. Checked notices for patrons and made sure a notice for automatic renewal was added. 3. Used the batch extend due dates tool (Tools > Patrons and circulation > Batch extend due dates) to extend the due dates for items issued to the 31 December 2021 - the preview listed the items checked out to patrons and the dates were extended. Step 5 - grep for borrower ~~~~~~~~~~~~~~~~~~~~~~~~~~ Not exactly sure what I was looking for, feel free to change back to sign off if this is not sufficient: 1. Did git greps for Koha::Old::Checkout and Koha::Checkout and saved results to a file. Then searched those files for join and borrower. 2. Did a git grep for borrower and saved results to a file. Searched that file for occurrences of Koha::Old::Checkout and Koha::Checkout that mentioned join and borrower. Only one item I came across but there is no join, so I don't think tat counts: t/db_dependent/Members/IssueSlip.t: or diag(Dumper(Koha::Checkouts->search({borrowernumber => $borrower->{borrowernumber}})->unblessed)); -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
