https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer <[email protected]> --- Hi Emmi, my apply script shows a bit of ending whitespace and the QA test tools show an error I haven't seen before: 1) QA tools error FAIL Koha/Patron/Debarments.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Patron::Debarments': current merge results [ Koha::Patron::Debarments, ] merging failed on 'Exporter' Could you please check this out? I've also done a first code review: 2) Please always use INSERT IGNORE when adding system preferences. This helps to keep them idempotent. + $dbh->do("INSERT INTO systempreferences (variable, value, options, explanation, type) VALUES ('DebarmentsToLiftAfterPayment', '', '', 'Lift these debarments after Borrower has paid his/her fees', 'textarea')"); 3) Gender neutral code comments etc. In English, you can use they/them/their to make your text gender neutral (wish it was that easy in German...) Like here: Lift these debarments after Borrower has paid his/her fees You can say: Lift these debarments after patron has paid their charges. See: https://wiki.koha-community.org/wiki/Terminology - prefer patron instead of borrower - prefer charges instead of fines/fees (not added yet, but changed in GUI) Similar for the written out pref text in the .yml file. 4) Unit tests pass :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
