https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate
             Status|Signed Off                  |Failed QA

--- Comment #47 from Katrin Fischer <[email protected]> ---
I've PQA on the base patch for adding the new classes, but I'll probably need
some help here especially for the API parts of the patch.

1) Translatability

You did great with View a few lines above, but here "Ignore matches" is not
translatable:

+                            $('td:eq(4) ul', nRow).prepend('<li><label><input
type="radio" data-import_record_id="'+aData['import_record_id']+'"
class="chosen" name="import_record_id_'+aData['import_record_id']+'_match"
value="none" ' + checked + disabled + ' > Ignore matches</label></li>');

Also here:

+                }).fail(function(){ alert("Unable to update match choices");
return false; });


2) Unrelated file change

reports/acquisitions_stats.pl
+    warn $strcalc;


I am marking this as a candidate for early inclusion in 22.05 as this enh is a
bit bigger and we have already reached soft feature freeze.

I am a little worried about side effects, like with the CLI tools for staged
MARC import, so would like to see those tested as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to