https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341
Nick Clemens <n...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |n...@bywatersolutions.com
--- Comment #21 from Nick Clemens <n...@bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #17)
> I disagree with removing the FK. Statistics should not keep a wrong/obsolete
> code, they are kept (ON DELETE SET NULL) however.
>
> There are different things, and different fixes: Statistics table is missing
> the FK (or does not have it on purpose), and the OpacRenewalBranch behaviour
> is badly designed.
>
> I don't think removing the FK is going into the correct direction, adding a
> separate column is definitely out of the scope here. We need a quick bugfix
> for the ugly 500 (that is blocker), and this patch is the way to go in my
> opinion.
I disagree here, I think we should remove the FK to branches as the quick fix.
While we may have opinions about how that feature was implemented, it has been
implemented. Statistics is a ledger of transactions - foreign keys are going to
remove/nullify data after the fact and I think that would be incorrect.
If Pseudonymized transactions are meant to mirror the statistics table then I
feel we should remove the FK for now, and fix the larger issue with OPACRenew
etc on a new bug.
Adding a new branch is going to add the branch in many places throughout Koha
and will impact workflows
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
