https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392
--- Comment #48 from Katrin Fischer <[email protected]> --- I haven't heard any good argument for tokens yet tbh. I think they would just obscure the templates and make them harder for people to work with. Koha is a huge application by now, that has a lot of strings, we'd also end up with tons of tokens. For the discussion: I think we need to discuss pros and cons of rewriting all our templates, because of the consequences: * A ton of pending code would have to be rewritten * Backporting patches would be harder for quite a while/versions * It would add another 'not so obvious' thing for development that is an additional barrier for people starting out * Template files will be bigger/contain more code. * We need to investigate a possible performance issue. * We could save 'space' as templates files won't need to be copied for each added language any longer. * We could see if we could shorten some of the constructs a bit more - the BLOCK/EXPAND especially. * We would need good documentation. * We would need to carefully the change for translators, not only locally, but also in Pootle. * We need to solve the issue where Pootle marks strings using {} placeholders as an error which makes things really hard for translators right now. So far I totally see the pros for using the new techniques for plural forms and context where words can have different meaning/need different translations, and we have already started to introduce them to the templates. But I am not totally persuaded that we should do a total switch (yet) I think this is not something that can go through dev/sign-off/QA/RM with only a few people involved in the discussion, it's something a lot more people need to be aware of and given the possibility to comment on and get onboard with, because a lot of people will be affected. So mailing list, dev meeting, consensus, coding guidelines, documentation. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
