https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076
--- Comment #29 from Thibaud Guillot <[email protected]> --- (In reply to Katrin Fischer from comment #24) > Hi Thibault, > > some small things: > > 1) Make sure that you start the subject line of your patch with Bug XXXX: > I'll fix this in QA. > > 2) Database update: We have a new format for the database update, the patch > still uses the old one. Please make sure to use the new format in future > patches, see: > https://wiki.koha-community.org/wiki/Database_updates > > 3) I'll rephrase the description of the pref a bit. If you'd like some help > for checking something in English, the native speakers on IRC are usually > willing to help out quickly. > > 4) I noticed your patch has your name as "ThibaudGLT". We can map this to > your full name if you want, but easiest is always to submit the patches with > the name you want to appear on the Dashboard and the release notes already. Hi Katrin, Thanks a lot for this complete review, sorry for the mistakes, but I understand now, I will keep this in mind for my future patchs. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
