https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172
--- Comment #24 from Alex Buckley <[email protected]> --- Created attachment 128817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128817&action=edit Bug 23172: The holds queue should check if a patron category is eligible to reserve an itemtype Currently when mapping items to pending holds the holds queue does not check the circulation rules to determine if the reserving patron category is eligible to reserve the item. This patch fixes that by calling C4::Reserves->CanItemBeReserved() when mapping items to pending reserves. Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Run HoldsQueue.pl 7. Notice in 'Circulation' > 'Holds queue' Patron A is listed as having a hold on the Book 8. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 9. Apply patch and restart services 10. Run HoldsQueue.pl 11. Notice in 'Circulation' > 'Holds queue' Patron A is listed as having a hold on the Continuing resource. Patron B is listed as having a hold on the Book -> These holds conform to the circulation rules 12. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
