https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <[email protected]> --- It might get too late and I might be misunderstanding it all, but I am not sure if this fix is in the right spot. Instead of introducing the onloan special case to the general method in Object.pm, would the solution not be to add it to the $properties_hashref? 321 $item->{cn_source} = delete $item->{'items.cn_source'}; # Because of C4::Biblio::_disambiguate 322 delete $item->{'items.cn_sort'}; # Because of C4::Biblio::_disambiguate 323 $item->{itemnumber} = $itemnumber; 324 $item->{biblionumber} = $biblionumber; 325 326 my $existing_cn_sort = $item_object->cn_sort; # set_or_blank will reset cn_sort to undef as we are not passing it 327 # We rely on Koha::Item->store to modify it if itemcallnumber or cn_source is modified 328 $item_object = $item_object->set_or_blank($item); 279 =head3 $object->set_or_blank( $properties_hashref ) 280 281 $object->set_or_blank( 282 { 283 property1 => $property1, 284 property2 => $property2, 285 property3 => $propery3, 286 } 287 ); 288 289 If not listed in $properties_hashref, the property will be set to the default 290 value defined at DB level, or nulled. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
