https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888
Bug ID: 29888
Summary: ->search_limited logic breaks searches
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
When writing unit tests for bug 29886, in which I was moving bug 23991 addtion
of Koha::Suggestions->search_limited I noticed a problem with how the query is
amended to deal with limitations: instead of relying on chained searches, it
tries (badly) to tweak the passed parameters.
This line was disturbing to me:
$params->{branchcode} = { -or => [ $userenv->{branch}, '' ] };
it means any query on branchcode will be overwritten! (another bug could be
filed to discuss that '' in there).
I propose to revisit the current ->search_limited implementations, and fix
them:
$ git grep 'sub search_limited'
Koha/ArticleRequests.pm:sub search_limited {
Koha/Patron/Discharge.pm:sub search_limited {
Koha/Patrons.pm:sub search_limited {
Koha/Reviews.pm:sub search_limited {
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
