https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066
--- Comment #12 from Fridolin Somers <[email protected]> --- (In reply to Lucas Gass from comment #9) > I think the follow-up is correct, the aria-label belongs on the button. Now > I think the the icon needs the aria-hidden="true" attribute. > > In fact the QA tool thinks so too: > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc > FAIL forbidden patterns > forbidden pattern: Font Awesome icons need the aria-hidden > attribute for > accessibility purpose (see bug 25166) (line 169) > forbidden pattern: Font Awesome icons need the aria-hidden > attribute for > accessibility purpose (see bug 25166) (line 282) Good catch, I added to follow-up -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
